Skip to content

Conversation

@zimbatm
Copy link
Contributor

@zimbatm zimbatm commented Apr 1, 2015

Taking #44 and going all the way.

TODO:

  • Unit tests for the adapters
  • Appengine compatibility

@jpatel531
Copy link
Contributor

sweet! can i merge?

@leggetter
Copy link
Contributor

If we are definitely happy to do so without testing some of the alternative adapters (the TODO above), sure.

I'd also like the peace of mind of some acceptance tests that actually hit the Pusher APIs.

But, we can create issues for both of these.

@jpatel531
Copy link
Contributor

when i run the tests i'm getting:

AttributeError: 'module' object has no attribute 'create_default_context'
in sync.py ln 19

@zimbatm
Copy link
Contributor Author

zimbatm commented Apr 1, 2015

It definitely needs testing, looking for 30% feedback right now

@leggetter
Copy link
Contributor

@jpatel531 What version of Python are you using?

@jpatel531
Copy link
Contributor

I've now tried it on 3.4

It's coming out with: bytes' object has no attribute 'encode' - which is failing every test

@zimbatm
Copy link
Contributor Author

zimbatm commented Apr 9, 2015

It's still missing adapter tests. At this point the library has been tested manually against python 3.4.3, 2.7.2 and 2.6.7 with the various backends.

@zimbatm zimbatm mentioned this pull request Apr 9, 2015
@jpatel531
Copy link
Contributor

For some reason the change to the packages list is failing the tests - it's looking for the folders within the pusher directory. Is that normal?

@zimbatm
Copy link
Contributor Author

zimbatm commented Apr 13, 2015

Why python version ?

it's looking for the folders within the pusher directory

I'm not sure what that means

@jpatel531
Copy link
Contributor

It was looking for the directory 'pusher/errors', 'pusher/aiohttp' etc.

@jpatel531
Copy link
Contributor

ok @zimbatm - i've tested it out on GAE with a new urlfetch backend, for which tests have been added (mind you - all the backend adapters only test for trigger success). everything's green on travis. there's probably still some stuff to do (like more tests), but i'm happy to get this up on pypi as soon as possible. WDYT?

@zimbatm
Copy link
Contributor Author

zimbatm commented Apr 24, 2015

:shipit: 🚢 🚀

jpatel531 added a commit that referenced this pull request Apr 24, 2015
@jpatel531 jpatel531 merged commit a49b73d into 1.0.0 Apr 24, 2015
@zimbatm zimbatm deleted the run-with-it branch May 18, 2015 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants